Skip to content

Skip MI300x8 tests since the machines are no longer available #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msaroufim merged 1 commit into from
Jan 7, 2026
Merged

Skip MI300x8 tests since the machines are no longer available #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/test_github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def github_config():

@pytest.mark.integration
@pytest.mark.asyncio
@pytest.mark.parametrize("gpu_type", [GitHubGPU.NVIDIA, GitHubGPU.MI300x8])
@pytest.mark.parametrize("gpu_type", [GitHubGPU.NVIDIA])
async def test_github_launcher_python_script(project_root: Path, github_config: GitHubConfig, gpu_type: GitHubGPU):
"""
Test GitHubLauncher with a real Python script using real GitHub Actions.
Expand Down Expand Up @@ -199,11 +199,14 @@ async def test_github_launcher_failing_script(project_root: Path, github_config:

@pytest.mark.integration
@pytest.mark.asyncio
@pytest.mark.skip(reason="MI300x8 machines are no longer available")
@pytest.mark.parametrize("gpu_type", [GitHubGPU.MI300x8])
async def test_github_launcher_multi_gpu(project_root: Path, github_config: GitHubConfig, gpu_type: GitHubGPU):
"""
Test GitHubLauncher with a real Python script using real GitHub Actions.
Tests all GPU types to verify runners are working.

Note: This test is skipped because MI300x8 machines are no longer available.
Comment on lines 206 to +209
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring states "Tests all GPU types to verify runners are working" but this test only tests MI300x8 and is now being skipped. Since the test is skipped, consider updating the docstring to clarify that this was a multi-GPU specific test for MI300x8 machines, rather than implying it tests all GPU types.

Suggested change
Test GitHubLauncher with a real Python script using real GitHub Actions.
Tests all GPU types to verify runners are working.
Note: This test is skipped because MI300x8 machines are no longer available.
Multi-GPU test of GitHubLauncher with a real Python script using real GitHub Actions,
specifically targeting MI300x8 GitHub runners to verify they are working.
Note: This test is currently skipped because MI300x8 machines are no longer available.

Copilot uses AI. Check for mistakes.
"""
launcher = GitHubLauncher(repo=github_config.repo, token=github_config.token, branch=github_config.branch)
reporter = MockProgressReporter("GitHub Integration Test")
Expand Down
Loading