lib: better error message for timeout error #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuonglm
force-pushed
the
feature/702
branch
from
fad5983
to
b62a412
Compare
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 73.59% 73.58% -0.02%
==========================================
Files 144 144
Lines 10529 10547 +18
==========================================
+ Hits 7749 7761 +12
- Misses 2322 2328 +6
Partials 458 458
Continue to review full report at Codecov.
|
mstoykov
reviewed
Sep 24, 2019
mstoykov
reviewed
Sep 24, 2019
TimeoutError is currently very uninformative, even if there are duplicated error messages. This PR change TimeoutError to a struct, which contains both the place and the timeout duration, so it helps constructing error message with more useful information to user. While at it, also prevent duplicating timeout error message for setup and teardown. Close #702
cuonglm
force-pushed
the
feature/702
branch
from
b62a412
to
bf6ea01
Compare
imiric
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeoutError is currently very uninformative, even if there are
duplicated error messages.
This PR change TimeoutError to a struct, which contains both the place
and the timeout duration, so it helps constructing error message with
more useful information to user.
While at it, also prevent duplicating timeout error message for setup
and teardown.
Close #702