Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: better error message for timeout error #1173

Merged
merged 3 commits into from
Sep 24, 2019
Merged

lib: better error message for timeout error #1173

merged 3 commits into from
Sep 24, 2019

Commits on Sep 24, 2019

  1. lib: better error message for timeout error 

    TimeoutError is currently very uninformative, even if there are
duplicated error messages.

This PR change TimeoutError to a struct, which contains both the place
and the timeout duration, so it helps constructing error message with
more useful information to user.

While at it, also prevent duplicating timeout error message for setup
and teardown.

Close #702
    @cuonglm
    cuonglm committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    bf6ea01 View commit details
    Browse the repository at this point in the history

  2. lib: add test for TimeoutError hint message

    @cuonglm
    cuonglm committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    e440a20 View commit details
    Browse the repository at this point in the history

  3. lib: always show timeout duration in error message

    @cuonglm
    cuonglm committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    e8a271c View commit details
    Browse the repository at this point in the history