Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud/v1: Aggregation in a dedicated pkg #3063

Merged
merged 6 commits into from
May 16, 2023
Merged

cloud/v1: Aggregation in a dedicated pkg #3063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb06221
cloud: Reorder functions to simplify reviews
codebien May 10, 2023
7244760
cloud/tests: Use StopWithTestError instead of Stop
codebien May 10, 2023
84fa4a0
cloud: Move aggregation in a dedicated file
codebien May 10, 2023
aa9e1e9
cloud: Moved aggregation to v1 pkg
codebien May 10, 2023
e127a23
cloud: Restore output tests
codebien May 10, 2023
10ecd76
Apply suggestions from code review
codebien May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
555 changes: 90 additions & 465 deletions output/cloud/output.go
View file
Open in desktop

Large diffs are not rendered by default.

709 changes: 6 additions & 703 deletions output/cloud/output_test.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions output/cloud/bench_test.go → output/cloud/v1/bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
)

func BenchmarkAggregateHTTP(b *testing.B) {
out, err := newOutput(output.Params{
out, err := newTestOutput(output.Params{
Logger: testutils.NewLogger(b),
JSONConfig: json.RawMessage(`{"noCompress": true, "aggregationCalcInterval": "200ms","aggregationPeriod": "200ms"}`),
ScriptOptions: lib.Options{
Expand Down Expand Up @@ -292,7 +292,7 @@ func BenchmarkHTTPPush(b *testing.B) {
},
)

out, err := newOutput(output.Params{
out, err := newTestOutput(output.Params{
Logger: testutils.NewLogger(b),
JSONConfig: json.RawMessage(fmt.Sprintf(`{
"host": "%s",
Expand Down
0 output/cloud/cloud_easyjson.go → output/cloud/v1/cloud_easyjson.go
View file
Open in desktop
File renamed without changes.
0 output/cloud/data.go → output/cloud/v1/data.go
View file
Open in desktop
File renamed without changes.
0 output/cloud/data_test.go → output/cloud/v1/data_test.go
View file
Open in desktop
File renamed without changes.
0 output/cloud/metrics_client.go → output/cloud/v1/metrics_client.go
View file
Open in desktop
File renamed without changes.
Loading