-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud/v1: Aggregation in a dedicated pkg #3063
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3063 +/- ##
==========================================
- Coverage 76.72% 76.69% -0.04%
==========================================
Files 229 230 +1
Lines 17110 17173 +63
==========================================
+ Hits 13127 13170 +43
- Misses 3140 3153 +13
- Partials 843 850 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It move some functions making more readable the next commit that will contain some refactor.
7752baa
to
e127a23
Compare
Rebased to resolve the conflicts, green now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few minor non-blocking comments 👍
Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
It splits the current output in a subpackage
v1
, it moves there the specific parts for version 1 and that are not expected to be used from version 2.It uses part of the work done in #3041, and it is a foundation for adding, on top of it, the versioning config option (#3041) and the
expv2
package (#2963).The proposed architecture should resolve the requested change in #2963 (comment).
I think you should review the code going through the commits one by one to check the evolution, otherwise, the final code could be too chaotic.
I think the test coverage is not high enough for the new
output/cloud/output.go
to have good confidence. If the architecture is confirmed I will add a bunch of them in a dedicated PR (we can keep this open till it is approved).