-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/2] Implement the fs.File.read
operation
#3219
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
force-pushed
the
experimental/fs-read
branch
from
July 20, 2023 15:24
c00f604
to
71f3ed7
Compare
oleiade
force-pushed
the
experimental/fs-read
branch
from
July 20, 2023 15:24
71f3ed7
to
fa92afc
Compare
Codecov Report
@@ Coverage Diff @@
## experimental/fs #3219 +/- ##
==================================================
Coverage ? 72.64%
==================================================
Files ? 263
Lines ? 20023
Branches ? 0
==================================================
Hits ? 14546
Misses ? 4557
Partials ? 920
Flags with carried forward coverage won't be shown. Click here to find out more. |
oleiade
changed the title
Experimental/fs read
[1/2] Implement the Jul 25, 2023
fs.File.read
operation
This was referenced Jul 26, 2023
oleiade
force-pushed
the
experimental/fs
branch
from
August 17, 2023 07:38
4461b00
to
ac9cef1
Compare
oleiade
force-pushed
the
experimental/fs
branch
2 times, most recently
from
August 24, 2023 12:56
6a1658b
to
9dd1a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This Pull Request adds an
⚠️ This PR is based on the ⚠️
read
method to thek6/experimental/fs
module'sfile
object, as per #3145.experimental/fs
branchIt allows to read a file into an ArrayBuffer.
The method resolves to either the number of bytes read during the operation or EOF (null) if there was nothing more to read.
It is possible for a read to successfully return with 0 bytes. This does not indicate EOF.
Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
ref #3165
closes #3145