bugfix: When OOO native histograms are disabled it should be a client error #9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ingesters replay data from Kafka, if they receive a non-client error they will continue to attempt to push the batch to the TSDB. In this PR, I'm translating Native Histogram OOO errors into client errors to ensure that we can continue with the next set of write requests when replaying data. Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
commented
Oct 8, 2024
gotjosh
commented
Oct 8, 2024
krajorama
reviewed
Oct 8, 2024
Signed-off-by: gotjosh <josue.abreu@gmail.com>
fionaliao
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
LGTM
I'm having a look at why the OOO integration test didn't catch this issue. I think it's a problem with the test rather than the code, so I think that can be investigated separately.
krajorama
approved these changes
Oct 8, 2024
Co-authored-by: Fiona Liao <fiona.y.liao@gmail.com>
gotjosh
deleted the
turn-ooo-native-histograms-error-into-client-errors
branch
grafanabot
pushed a commit
that referenced
this pull request
Oct 8, 2024
… error (#9567) * When OOO native histograms are disabled it should be a client error When ingesters replay data from Kafka, if they receive a non-client error they will continue to attempt to push the batch to the TSDB. In this PR, I'm translating Native Histogram OOO errors into client errors to ensure that we can continue with the next set of write requests when replaying data. Signed-off-by: gotjosh <josue.abreu@gmail.com> * Address review feedback Signed-off-by: gotjosh <josue.abreu@gmail.com> * Update docs/sources/mimir/manage/mimir-runbooks/_index.md Co-authored-by: Fiona Liao <fiona.y.liao@gmail.com> * lint Signed-off-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: gotjosh <josue.abreu@gmail.com> Co-authored-by: Fiona Liao <fiona.y.liao@gmail.com> (cherry picked from commit f737a53)
gotjosh
added a commit
that referenced
this pull request
Oct 8, 2024
… error (#9567) (#9569) * When OOO native histograms are disabled it should be a client error When ingesters replay data from Kafka, if they receive a non-client error they will continue to attempt to push the batch to the TSDB. In this PR, I'm translating Native Histogram OOO errors into client errors to ensure that we can continue with the next set of write requests when replaying data. Signed-off-by: gotjosh <josue.abreu@gmail.com> * Address review feedback Signed-off-by: gotjosh <josue.abreu@gmail.com> * Update docs/sources/mimir/manage/mimir-runbooks/_index.md Co-authored-by: Fiona Liao <fiona.y.liao@gmail.com> * lint Signed-off-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: gotjosh <josue.abreu@gmail.com> Co-authored-by: Fiona Liao <fiona.y.liao@gmail.com> (cherry picked from commit f737a53) Co-authored-by: gotjosh <josue.abreu@gmail.com>
4 tasks
4 tasks
seizethedave
added a commit
that referenced
this pull request
Oct 16, 2024
This applies the same logic from #9567 to block-builder. This currently has the effect of stopping block-builder ingestion when an OOO native histogram is encountered.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When ingesters replay data from Kafka, if they receive a non-client error, they will continue to attempt to push the batch to the TSDB.
In this PR, I'm translating Native Histogram OOO errors into client errors to ensure that we can continue with the next set of write requests when replaying data.
This was introduced as part of #7175
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.