remove asset pipeline from example test projects #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesfredley
changed the title
matrei
requested changes
Dec 21, 2024
| @@ -29,7 +25,6 @@ dependencies { | |||
| implementation "org.springframework.boot:spring-boot-starter-tomcat" | |||
| implementation "org.springframework.boot:spring-boot-starter-validation" | |||
| console "org.grails:grails-console" | |||
| runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails" | |||
There was a problem hiding this comment.
This one should be kept, as there are assets in the app. It's only the gradle plugin that can be removed. The gradle plugin will pre-compile assets when packaging the app. We won't do that with a test app. However the library is still needed at runtime when running tests to serve assets.
There was a problem hiding this comment.
Ok, I got a little over excited to remove it completely, so that is never needed updated again in the example test projects. I'll update this one and the PR on gorm-hibernate5.
| @@ -24,7 +20,6 @@ dependencies { | |||
| implementation "org.springframework.boot:spring-boot-starter-tomcat" | |||
| implementation "org.springframework.boot:spring-boot-starter-validation" | |||
| console "org.grails:grails-console" | |||
| runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails" | |||
| @@ -27,7 +23,6 @@ dependencies { | |||
| implementation "org.springframework.boot:spring-boot-starter-tomcat" | |||
| implementation "org.springframework.boot:spring-boot-starter-validation" | |||
| console "org.grails:grails-console" | |||
| runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails" | |||
matrei
reviewed
Dec 21, 2024
| @@ -1,4 +1,5 @@ | |||
| projectVersion=9.0.0-SNAPSHOT | |||
| assetPipelineVersion=5.0.4 | |||
There was a problem hiding this comment.
This is not used, right? Remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.