Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove asset pipeline from example test projects #781

Closed
wants to merge 2 commits into from
+1 −15
Closed

remove asset pipeline from example test projects #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91e2f78
move asset-pipeline Gradle plugin version to one location
jamesfredley Dec 20, 2024
7b4fa7c
remove asset-pipeline from example projects
jamesfredley Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions examples/grails3-hibernate5-mongodb/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
plugins {
id "com.bertramlabs.asset-pipeline" version "5.0.4"
}

group "examples"

dependencies {
Expand Down Expand Up @@ -29,7 +25,6 @@ dependencies {
implementation "org.springframework.boot:spring-boot-starter-tomcat"
implementation "org.springframework.boot:spring-boot-starter-validation"
console "org.grails:grails-console"
runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails"
runtimeOnly "com.h2database:h2"
Copy link
Contributor

@matrei matrei Dec 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be kept, as there are assets in the app. It's only the gradle plugin that can be removed. The gradle plugin will pre-compile assets when packaging the app. We won't do that with a test app. However the library is still needed at runtime when running tests to serve assets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I got a little over excited to remove it completely, so that is never needed updated again in the example test projects. I'll update this one and the PR on gorm-hibernate5.

runtimeOnly "org.apache.tomcat:tomcat-jdbc"
runtimeOnly "org.fusesource.jansi:jansi"
Expand Down
5 changes: 0 additions & 5 deletions examples/grails3-mongodb-database-per-tenant/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
plugins {
id "com.bertramlabs.asset-pipeline" version "5.0.4"
}

dependencies {
implementation project(":grails-plugin")
implementation "org.mongodb:mongodb-driver-sync"
Expand All @@ -24,7 +20,6 @@ dependencies {
implementation "org.springframework.boot:spring-boot-starter-tomcat"
implementation "org.springframework.boot:spring-boot-starter-validation"
console "org.grails:grails-console"
runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails"
runtimeOnly "com.h2database:h2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep

runtimeOnly "org.apache.tomcat:tomcat-jdbc"
runtimeOnly "org.fusesource.jansi:jansi"
Expand Down
5 changes: 0 additions & 5 deletions examples/grails3-mongodb/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
plugins {
id "com.bertramlabs.asset-pipeline" version "5.0.4"
}

group "examples"

dependencies {
Expand All @@ -27,7 +23,6 @@ dependencies {
implementation "org.springframework.boot:spring-boot-starter-tomcat"
implementation "org.springframework.boot:spring-boot-starter-validation"
console "org.grails:grails-console"
runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails"
runtimeOnly "com.h2database:h2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep

runtimeOnly "org.apache.tomcat:tomcat-jdbc"
runtimeOnly "org.fusesource.jansi:jansi"
Expand Down
1 change: 1 addition & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
projectVersion=9.0.0-SNAPSHOT
assetPipelineVersion=5.0.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used, right? Remove?

asciidoctorGradleVersion=4.0.3
datastoreVersion=9.0.0-SNAPSHOT
gradleNexusPublishPluginVersion=1.3.0
Expand Down
Loading