Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed goroutine leak in subscriptions #626

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fixed goroutine leak in subscriptions #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions subscriptions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,14 @@ func (s *Schema) subscribe(ctx context.Context, queryString string, operationNam
responses := r.Subscribe(ctx, res, op)
c := make(chan interface{})
go func() {
Loop:
for resp := range responses {
c <- &Response{
Data: resp.Data,
Errors: resp.Errors,
select {
case c <- &Response{Data: resp.Data, Errors: resp.Errors}:
continue

case <-ctx.Done():
break Loop
}
}
close(c)
Expand Down
Loading