Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed goroutine leak in subscriptions #626

Merged

Conversation

korotin
Copy link
Contributor

@korotin korotin commented Nov 23, 2023

We have goroutine leak here if events will happen in following order:

Described situation may seem rare, but in our project with hundreds events per second that leak happened rather often. We tested this fix in production environment and it solved the problem.

@pavelnikolov

@pavelnikolov pavelnikolov merged commit a226fe8 into graph-gophers:master Nov 28, 2023
2 checks passed
@pavelnikolov
Copy link
Member

Thank you for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants