Skip to content

Comments

Subgraph Composition: More validations#5811

Merged
incrypto32 merged 4 commits intomasterfrom
krishna/sc-validations-next
Feb 15, 2025
Merged

Subgraph Composition: More validations#5811
incrypto32 merged 4 commits intomasterfrom
krishna/sc-validations-next

Conversation

@incrypto32
Copy link
Member

This PR

  • Sets a hard limit (5) on the number of datasources that can be composed together
  • Prevents nesting of subgraph datasources

@incrypto32 incrypto32 force-pushed the krishna/sc-validations-next branch from 344fad3 to b6b97d7 Compare February 11, 2025 09:50
@incrypto32 incrypto32 force-pushed the krishna/sc-validations-next branch from b6b97d7 to f23cbb4 Compare February 11, 2025 10:17
@zorancv zorancv self-requested a review February 13, 2025 17:08
@zorancv
Copy link
Contributor

zorancv commented Feb 14, 2025

Not directly related, but it would be nice to have a test that checks if a source entity that is aggregated would produce error.

Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@incrypto32 incrypto32 merged commit 4e41104 into master Feb 15, 2025
6 checks passed
@incrypto32 incrypto32 deleted the krishna/sc-validations-next branch October 13, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants