Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Add response stream to Response Section #1135

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

robrichard
Copy link
Contributor

@robrichard robrichard commented Feb 24, 2025

I updated section 7 to formally define Response as the map returned by graphql query/mutations. I am also adding a definition of "Response Stream" to section 7 as subscriptions are not mentioned in this section. The defer/stream spec edits will also add a definition for an Incremental Stream here.

I also Linked Response Stream in the execution section to this new definition, and made the existing definition of source stream linkable.

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 164454f
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/67bcda403ec8d100092c0f67
😎 Deploy Preview https://deploy-preview-1135--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@robrichard robrichard requested a review from benjie February 24, 2025 18:53
@robrichard robrichard changed the title Add response stream to Response Section Editorial: Add response stream to Response Section Mar 1, 2025
Copy link
Collaborator

@leebyron leebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pure win. nice cleanup and makes this more accurate

@leebyron leebyron added the ✏️ Editorial PR is non-normative or does not influence implementation label Mar 6, 2025
@leebyron leebyron merged commit b41339a into main Mar 6, 2025
9 checks passed
@leebyron leebyron deleted the robrichard/response-stream branch March 6, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants