Support configuring DNS SANs for X509 SVIDs using WorkloadIdentity resource #50676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
changed the title
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
|
Amplify deployment status
|
strideynet
commented
Jan 1, 2025
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
github-actions
bot
requested review from
bernardjkim,
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato and
xinding33
strideynet
added
the
no-changelog
tigrato
approved these changes
Jan 2, 2025
timothyb89
approved these changes
Jan 3, 2025
public-teleport-github-review-bot
bot
removed request for
r0mant,
marcoandredinis,
mmcallister,
zmb3,
bernardjkim,
hugoShaka,
xinding33 and
ptgott
Co-authored-by: Tim Buckley <tim@goteleport.com>
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
marcoandredinis
approved these changes
Jan 6, 2025
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Jan 6, 2025
…source (#50676) * Extend the protobuf * Wire up DNS SAN field to issuance code * Regenerate tfschema * Add DNS SANs to the audit event * Add test * Rename to x509 * Add test/check that validates hostname generated * Fix TS proto * Update lib/auth/machineid/workloadidentityv1/decision_test.go Co-authored-by: Tim Buckley <tim@goteleport.com> --------- Co-authored-by: Tim Buckley <tim@goteleport.com>
strideynet
added a commit
that referenced
this pull request
Jan 6, 2025
…source (#50676) * Extend the protobuf * Wire up DNS SAN field to issuance code * Regenerate tfschema * Add DNS SANs to the audit event * Add test * Rename to x509 * Add test/check that validates hostname generated * Fix TS proto * Update lib/auth/machineid/workloadidentityv1/decision_test.go Co-authored-by: Tim Buckley <tim@goteleport.com> --------- Co-authored-by: Tim Buckley <tim@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
…source (#50676) (#50761) * Extend the protobuf * Wire up DNS SAN field to issuance code * Regenerate tfschema * Add DNS SANs to the audit event * Add test * Rename to x509 * Add test/check that validates hostname generated * Fix TS proto * Update lib/auth/machineid/workloadidentityv1/decision_test.go --------- Co-authored-by: Tim Buckley <tim@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
…source (#50676) (#50762) * Extend the protobuf * Wire up DNS SAN field to issuance code * Regenerate tfschema * Add DNS SANs to the audit event * Add test * Rename to x509 * Add test/check that validates hostname generated * Fix TS proto * Update lib/auth/machineid/workloadidentityv1/decision_test.go --------- Co-authored-by: Tim Buckley <tim@goteleport.com>
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…source (gravitational#50676) * Extend the protobuf * Wire up DNS SAN field to issuance code * Regenerate tfschema * Add DNS SANs to the audit event * Add test * Rename to x509 * Add test/check that validates hostname generated * Fix TS proto * Update lib/auth/machineid/workloadidentityv1/decision_test.go Co-authored-by: Tim Buckley <tim@goteleport.com> --------- Co-authored-by: Tim Buckley <tim@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #44006
See RFD191: #49133
Adds support for issuing X509 SVIDs including DNS SANs. This is compatible with the templating system.