powsybl-dependencies v2025.3.0 #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Mathieu-Deharbe
approved these changes
Jan 14, 2026
| @Column(name = "connectedComponentMode") | ||
| @Enumerated(EnumType.STRING) | ||
| private LoadFlowParameters.ConnectedComponentMode connectedComponentMode; | ||
| private LoadFlowParameters.ComponentMode connectedComponentMode; |
Contributor
There was a problem hiding this comment.
If the type name changes you should probably change the variable name too :
Suggested change
| private LoadFlowParameters.ComponentMode connectedComponentMode; | |
| private LoadFlowParameters.ComponentMode componentMode; |
(edit : ok I can see that this gets complicated given that this is an entity, maybe it is better to keep it like this, do as you wish)
|
Mathieu-Deharbe
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
migrate parameters ComponentMode according to powsybl release : powsybl/powsybl-core#3583