-
Notifications
You must be signed in to change notification settings - Fork 1
powsybl-dependencies v2025.3.0 #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1f56154
powsybl-dependencies v2025.3.0
EtienneLt 7c54aa0
fix
EtienneLt 37a920a
Merge branch 'main' into powsybl-dependencencies-v2025.3.0
EtienneLt 331d71c
Merge branch 'main' into powsybl-dependencies-v2025.3.0
EtienneLt 7b1dd20
empty commit to trigger ci
EtienneLt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -88,7 +88,7 @@ public class LoadFlowParametersEntity { | |||||
|
|
||||||
| @Column(name = "connectedComponentMode") | ||||||
| @Enumerated(EnumType.STRING) | ||||||
| private LoadFlowParameters.ConnectedComponentMode connectedComponentMode; | ||||||
| private LoadFlowParameters.ComponentMode connectedComponentMode; | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the type name changes you should probably change the variable name too :
Suggested change
(edit : ok I can see that this gets complicated given that this is an entity, maybe it is better to keep it like this, do as you wish) |
||||||
|
|
||||||
| @Column(name = "hvdcAcEmulation", columnDefinition = "boolean default true", nullable = false) | ||||||
| private boolean hvdcAcEmulation = true; | ||||||
|
|
@@ -175,7 +175,7 @@ private void assignCommonValues(LoadFlowParameters allCommonValues) { | |||||
| balanceType = allCommonValues.getBalanceType(); | ||||||
| dcUseTransformerRatio = allCommonValues.isDcUseTransformerRatio(); | ||||||
| countriesToBalance = allCommonValues.getCountriesToBalance().stream().map(Country::toString).collect(Collectors.toSet()); | ||||||
| connectedComponentMode = allCommonValues.getConnectedComponentMode(); | ||||||
| connectedComponentMode = allCommonValues.getComponentMode(); | ||||||
| hvdcAcEmulation = allCommonValues.isHvdcAcEmulation(); | ||||||
| dcPowerFactor = allCommonValues.getDcPowerFactor(); | ||||||
| } | ||||||
|
|
@@ -205,7 +205,7 @@ public LoadFlowParameters toLoadFlowParameters() { | |||||
| .setBalanceType(this.getBalanceType()) | ||||||
| .setDcUseTransformerRatio(this.isDcUseTransformerRatio()) | ||||||
| .setCountriesToBalance(this.getCountriesToBalance().stream().map(Country::valueOf).collect(Collectors.toSet())) | ||||||
| .setConnectedComponentMode(this.getConnectedComponentMode()) | ||||||
| .setComponentMode(this.getConnectedComponentMode()) | ||||||
| .setHvdcAcEmulation(this.isHvdcAcEmulation()) | ||||||
| .setDcPowerFactor(this.getDcPowerFactor()); | ||||||
| } | ||||||
|
|
||||||
13 changes: 13 additions & 0 deletions
13
src/main/resources/db/changelog/changesets/changelog_20260801T170000Z.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <?xml version="1.1" encoding="UTF-8" standalone="no"?> | ||
| <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" xmlns:pro="http://www.liquibase.org/xml/ns/pro" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-latest.xsd http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"> | ||
| <changeSet author="lesoteti" id="1764164817687-1"> | ||
| <update tableName="load_flow_parameters"> | ||
| <column name="connected_component_mode" value="MAIN_CONNECTED"/> | ||
| <where>connected_component_mode = 'MAIN'</where> | ||
| </update> | ||
| <update tableName="load_flow_parameters"> | ||
| <column name="connected_component_mode" value="ALL_CONNECTED"/> | ||
| <where>connected_component_mode = 'ALL'</where> | ||
| </update> | ||
| </changeSet> | ||
| </databaseChangeLog> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the type name changes you should probably change the variable name too :
(edit : ok I can see that this gets complicated given that this is an entity, maybe it is better to keep it like this, do as you wish)