Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components.js #3566

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Update components.js #3566

merged 5 commits into from
Oct 18, 2023

Conversation

ashifalinadaf
Copy link
Contributor

Adding metadata for 'selectmultiple' component for test.

Deploy Preview

What does this PR do?

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Adding metadata for 'selectmultiple' component for test.
@ashifalinadaf ashifalinadaf mentioned this pull request Oct 16, 2023
54 tasks
@taysea
Copy link
Collaborator

taysea commented Oct 17, 2023

This looks good! Feel free to edit the other components in this file too. Let me know if you need help to edit it in this PR!

@ashifalinadaf
Copy link
Contributor Author

Thank you @taysea for the confirmation, I will add tags to other components too and let you know.

@taysea taysea self-requested a review October 18, 2023 22:30
@taysea taysea merged commit 6ed2dea into master Oct 18, 2023
@taysea taysea deleted the ashifalinadaf-patch-1 branch October 18, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants