Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components.js #3569

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Update components.js #3569

merged 4 commits into from
Oct 26, 2023

Conversation

ashifalinadaf
Copy link
Contributor

Adding meta data to the components.

Deploy Preview

What does this PR do?

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Adding meta data to the components.
@ashifalinadaf ashifalinadaf mentioned this pull request Oct 20, 2023
54 tasks
@taysea taysea self-requested a review October 26, 2023 15:59
@taysea taysea merged commit 9fda1e8 into master Oct 26, 2023
5 of 6 checks passed
@taysea taysea deleted the ashifalinadaf-patch-1 branch October 26, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants