-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes #732
Small fixes #732
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR).
API leaks
|
Package | Leaked API symbols |
---|---|
grpc | Any $1.Duration ServerHandler |
This check can be disabled by tagging the PR with skip-leaking-check
.
Package publish validation ✔️
Package | Version | Status |
---|---|---|
package:grpc | 4.0.2-wip | WIP (no publish necessary) |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
I also looked into the leaking API symbols:
ServerHandler
is only visible for testing (the next version of the tool will detect this and not complain anymore)Duration
is used in an error constructor, we don't even want to expose that I believe.So all good.