Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #732

Merged
merged 11 commits into from
Sep 6, 2024
Merged

Small fixes #732

merged 11 commits into from
Sep 6, 2024

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Sep 2, 2024

I also looked into the leaking API symbols:

  • ServerHandler is only visible for testing (the next version of the tool will detect this and not complain anymore)
  • 'Any' as well now.
  • Duration is used in an error constructor, we don't even want to expose that I believe.

So all good.

Copy link

github-actions bot commented Sep 2, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
grpc None 4.0.2 4.0.2-wip 4.0.2 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage
lib/src/shared/status.dart 💚 59 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc Any
$1.Duration
ServerHandler

This check can be disabled by tagging the PR with skip-leaking-check.

Package publish validation ✔️
Package Version Status
package:grpc 4.0.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@grpc grpc deleted a comment from github-actions bot Sep 2, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 2, 2024
@pull-request-size pull-request-size bot added size/S and removed size/M labels Sep 2, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 2, 2024
@mosuem mosuem merged commit 8177633 into master Sep 6, 2024
21 checks passed
@kevmoo kevmoo deleted the smallFixes branch September 24, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants