fix: Correctly ingest logs #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa/ecs-parser
branch
7 times, most recently
from
77ccb85
to
b7a57f5
Compare
This parser provides the correct time format. Inspired by https://github.com/fluent/fluent-bit/blob/master/conf/parsers.conf
akash1810
force-pushed
the
aa/ecs-parser
branch
from
b7a57f5
to
2a8fb05
Compare
akash1810
changed the title
docker parser for ECS logs
akash1810
force-pushed
the
aa/ecs-parser
branch
from
84db94f
to
2a8fb05
Compare
This was referenced Oct 13, 2023
akash1810
changed the title
AshCorr
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This parser provides the correct time format for logs generated from ECS.
We were previously parsing the time field as
%d/%b/%Y:%H:%M:%S %z, a different format, which was causing some logs to be dropped. It's difficult to identify exactly which log lines were dropped, however with this change the parsing errors seen below are all removed.This change also fixes the hydration of logs with Stack, Stage, App markers by moving it to a separate directive. The process is now:
logfield tomessagemessagefield as JSONImages
Firelens logs showing parsing errors, and dropped lines
Central ELK before
Central ELK after