Merged
Conversation
e0e4fdf to
d3148c4
Compare
waisingyiu
approved these changes
Aug 1, 2025
Contributor
There was a problem hiding this comment.
It looks great, thank you @LAKSHMIRPILLAI .
Currently the CD has not been set up for PROD, but there is a PROD stack, presumably from one of the past commits of the main branch. So this PR will not be deployed to the PROD even after being merged. After we enable "block all public access" option in the panda S3 bucket, the PROD stack will probably stop working.
Having discussed with the team, we didn't think it was much of a concern because the editorial collaboration was not in production use at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR is to bump pan-domain-node to v1.2
This is done to address the high severity vulnerability reported as FSBP S3.8 the bucket pan-domain-auth-settings should block public access here
This pull request bumps the pan-domain-node dependency to version 1.2.0 so that it reads the public key files by AWS SDK rather than unauthenticated direct HTTP request.
Changes are done in pan-domain-node library (guardian/pan-domain-node#47) to get the public key files with AWS SDK that requires AWS credentials in the execution environment.
How to test
Test in CODE (IN PROGRESS)
Steps
Deploy the branch to Editorial Tools::Editorial Collaboration
Open Composer CODE and load the page.
Enable Enable collaborative editing: this currently logs steps out to the console feature switch and reload the page
Check the Network tab to look for the POST requests to https://editorial-collaboration.code.dev-gutools.co.uk .We need to edit the body in order to trigger this
If it returns 200/201 or ok , it seems the changes are working
Also look for any error messages in the logs