Skip to content

Update @guardian/cdk, and therefore AWS sdk also#24

Merged
liamness merged 1 commit intomainfrom
update-guardian-cdk
Oct 30, 2025
Merged

Update @guardian/cdk, and therefore AWS sdk also#24
liamness merged 1 commit intomainfrom
update-guardian-cdk

Conversation

@liamness
Copy link
Contributor

@liamness liamness commented Oct 28, 2025

What does this change?

We need to move away from @aws-sdk v2 dependencies as they are EOL (see guardian/workflow#1273). Bumping @guardian/cdk will achieve this.

Had to do some fiddling to get RiffRaff to deploy using this new version, see this (reverted) commit. Might have to do that for other projects that are bumping @guardian/cdk.

How to test

Copied largely from #23:

  1. Deploy the branch to CODE (we only have a CODE instance, and I've already deployed to it)
  2. Open Composer CODE and load the page.
  3. Enable collaborative editing feature flag and reload the page
  4. Trigger a change (e.g. by editing the body) and look in your developer tools for the POST requests to https://editorial-collaboration.code.dev-gutools.co.uk
  5. If it returns 200/201 or ok , it seems the changes are working
  6. Also look for any error messages in the logs

How can we measure success?

No longer pulling in deprecated dependency

Have we considered potential risks?

Low level of risk as this project is not used in production

@liamness liamness force-pushed the update-guardian-cdk branch 3 times, most recently from 273a899 to af7e338 Compare October 28, 2025 12:52
@liamness liamness force-pushed the update-guardian-cdk branch from af7e338 to 468342b Compare October 28, 2025 13:03
@liamness liamness force-pushed the update-guardian-cdk branch 3 times, most recently from 6d4d3fd to 468342b Compare October 28, 2025 14:39
@liamness liamness added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Oct 28, 2025
@emdash-ie emdash-ie added this to the Health milestone Oct 29, 2025
@liamness liamness merged commit 58db016 into main Oct 30, 2025
5 checks passed
@liamness liamness deleted the update-guardian-cdk branch October 30, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants