Run tests in common and api models as part of CI #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindseydew
approved these changes
Apr 10, 2024
| @@ -38,7 +38,7 @@ jobs: | |||
| role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }} | |||
|
|
|||
| - name: Compile, test and assembly | |||
| run: sbt "project eventconsumer" "compile" "test" "assembly" | |||
| run: sbt "project commoneventconsumer" "compile" "test" "project eventconsumer" "compile" "test" "assembly" | |||
There was a problem hiding this comment.
Do you mean common here? Or is commoneventconsumer a shared app?
There was a problem hiding this comment.
Yeah, the commoneventconsumer is the shared app which eventconsumer depends on - https://github.com/guardian/mobile-n10n/blob/main/build.sbt#L328
| @@ -40,7 +40,7 @@ jobs: | |||
| role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }} | |||
|
|
|||
| - name: Compile, test and package | |||
| run: sbt "project notification" "compile" "test" "debian:packageBin" | |||
| run: sbt "project common" "compile" "test" "project commonscheduledynamodb" "compile" "test" "project notification" "compile" "test" "debian:packageBin" | |||
There was a problem hiding this comment.
is commonscheduledynamodb a shared app?
There was a problem hiding this comment.
Yes, notification depends on both common and commonscheduledynamodb - https://github.com/guardian/mobile-n10n/blob/main/build.sbt#L163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
It was reported that the tests in the common projects such as
commonandapi-modelswere not executed as part of CI.This PR changes the GHA workflows to run tests in the common projects on which the target project depends.
How to test
The Github action works successfully as expected.
No changes to the source code or build configuration were made.