-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in common and api models as part of CI #1215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question about a couple of the shared apps names, but it's been used in a couple of places so it looks deliberate
@@ -38,7 +38,7 @@ jobs: | |||
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }} | |||
|
|||
- name: Compile, test and assembly | |||
run: sbt "project eventconsumer" "compile" "test" "assembly" | |||
run: sbt "project commoneventconsumer" "compile" "test" "project eventconsumer" "compile" "test" "assembly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean common here? Or is commoneventconsumer
a shared app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the commoneventconsumer
is the shared app which eventconsumer
depends on - https://github.com/guardian/mobile-n10n/blob/main/build.sbt#L328
@@ -40,7 +40,7 @@ jobs: | |||
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }} | |||
|
|||
- name: Compile, test and package | |||
run: sbt "project notification" "compile" "test" "debian:packageBin" | |||
run: sbt "project common" "compile" "test" "project commonscheduledynamodb" "compile" "test" "project notification" "compile" "test" "debian:packageBin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is commonscheduledynamodb
a shared app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, notification
depends on both common
and commonscheduledynamodb
- https://github.com/guardian/mobile-n10n/blob/main/build.sbt#L163
What does this change?
It was reported that the tests in the common projects such as
common
andapi-models
were not executed as part of CI.This PR changes the GHA workflows to run tests in the common projects on which the target project depends.
How to test
The Github action works successfully as expected.
No changes to the source code or build configuration were made.