Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests in common and api models as part of CI #1215

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Run tests in common and api models as part of CI #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27d304e
Run tests in dependent projects as part of CI
waisingyiu Apr 10, 2024
b9a13a1
Fixed typo
waisingyiu Apr 10, 2024
fade517
Fixed typo
waisingyiu Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/event-consumer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}

- name: Compile, test and assembly
run: sbt "project eventconsumer" "compile" "test" "assembly"
run: sbt "project commoneventconsumer" "compile" "test" "project eventconsumer" "compile" "test" "assembly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean common here? Or is commoneventconsumer a shared app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the commoneventconsumer is the shared app which eventconsumer depends on - https://github.com/guardian/mobile-n10n/blob/main/build.sbt#L328


- name: Copy jar to root
run: cp eventconsumer/target/scala-*/eventconsumer.jar .
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fake-breaking-news.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}

- name: Compile, test and assembly
run: sbt "project fakebreakingnewslambda" "compile" "test" "assembly"
run: sbt "project common" "compile" "test" "project api-models" "compile" "test" "project fakebreakingnewslambda" "compile" "test" "assembly"

- name: Copy jar to root
run: cp fakebreakingnewslambda/target/scala-*/fakebreakingnewslambda.jar .
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/football.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}

- name: Compile, test and assembly
run: sbt "project football" "compile" "test" "assembly"
run: sbt "project api-models" "compile" "test" "project football" "compile" "test" "assembly"

- name: Copy jar to root
run: cp football/target/scala-*/football.jar .
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notification-worker-lambdas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
mask-password: 'true'

- name: Compile and test
run: sbt "project notificationworkerlambda" "compile" "test"
run: sbt "project common" "compile" "test" "project notificationworkerlambda" "compile" "test"

- name: Build docker image
run: sbt docker:publishLocal
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}

- name: Compile, test and package
run: sbt "project notification" "compile" "test" "debian:packageBin"
run: sbt "project common" "compile" "test" "project commonscheduledynamodb" "compile" "test" "project notification" "compile" "test" "debian:packageBin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is commonscheduledynamodb a shared app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, notification depends on both common and commonscheduledynamodb - https://github.com/guardian/mobile-n10n/blob/main/build.sbt#L163


- name: Upload to riff-raff
uses: guardian/actions-riff-raff@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/registration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
npm run synth

- name: Compile, test and package
run: sbt "project registration" "compile" "test" "debian:packageBin"
run: sbt "project common" "compile" "test" "project registration" "compile" "test" "debian:packageBin"

- name: Upload to riff-raff
uses: guardian/actions-riff-raff@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/report-extractor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}

- name: Compile, test and assembly
run: sbt "project reportextractor" "compile" "test" "assembly"
run: sbt "project common" "compile" "test" "project reportextractor" "compile" "test" "assembly"

- name: Copy jar to root
run: cp reportextractor/target/scala-*/reportextractor.jar .
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}

- name: Compile, test and package
run: sbt "project report" "compile" "test" "debian:packageBin"
run: sbt "project common" "compile" "test" "project report" "compile" "test" "debian:packageBin"

- name: Upload to riff-raff
uses: guardian/actions-riff-raff@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/schedule-lambda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}

- name: Compile, test and assembly
run: sbt "project schedule" "compile" "test" "assembly"
run: sbt "project commonscheduledynamodb" "compile" "test" "project schedule" "compile" "test" "assembly"

- name: Copy jar to root
run: cp schedulelambda/target/scala-*/schedule.jar .
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/slo-monitor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}

- name: Compile, test and assembly
run: sbt "project slomonitor" "compile" "test" "assembly"
run: sbt "project commoneventconsumer" "compile" "test" "project slomonitor" "compile" "test" "assembly"

- name: Copy jar to root
run: cp slomonitor/target/scala-*/slomonitor.jar .
Expand Down
Loading