Add riff raff project tag #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
approved these changes
Sep 20, 2024
|
This will have a huge positive impact to so many scenarios, e.g. auditing, incident response, etc. 💎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Riff raff tags every resource it deploys with a set of common tags, and this patch adds a new one called
gu:riff-raff-projectwith the name of the riff raff project.This is useful to quickly find the riff raff project, and hence the deployment history, of any resource that's been deployed by riff raff.
How to test
This can easily tested by deploying to riff raff CODE, and using it to deploy an application. We've deployed cdk playground and amiable and saw that the new tag is being set correctly.
Have we considered potential risks?
Merging this PR means that every project that gets deployed with riff raff after this change will have to perform a tag update across all the project resources. It's a one time cost that shouldn't cause any issues.