Live single fits combined bug #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you are on this, could you add units to the y axis of the count plots? I guess [s^{-1}]? |
Done - I also made it more descriptive (i.e. count of what?) |
Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
titodalcanton
approved these changes
Aug 4, 2023
|
There are a few of unused variables and other minor things I want to fix, will open a PR in a moment. |
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
* Take precentile of rate, not count * make change to mean as well * Fix to label * Update bin/live/pycbc_live_plot_combined_single_fits Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update bin/live/pycbc_live_combine_single_fits --------- Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
titodalcanton
added a commit
to titodalcanton/pycbc
that referenced
this pull request
Jan 16, 2024
* Take precentile of rate, not count * make change to mean as well * Fix to label * Update bin/live/pycbc_live_plot_combined_single_fits Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update bin/live/pycbc_live_combine_single_fits --------- Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* Take precentile of rate, not count * make change to mean as well * Fix to label * Update bin/live/pycbc_live_plot_combined_single_fits Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update bin/live/pycbc_live_combine_single_fits --------- Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Take precentile of rate, not count * make change to mean as well * Fix to label * Update bin/live/pycbc_live_plot_combined_single_fits Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update bin/live/pycbc_live_combine_single_fits --------- Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rates plot was showing percentile values above the largest rate, which makes no sense
https://ldas-jobs.ligo.caltech.edu/~gareth.cabourndavies/pycbclive/combine_average_weighting/testing/H1-2023_07_14-2023_08_02-TRIGGER_FITS_COMBINED-counts-original.png
This fix changes to use the percentile of the rate rather than counts, so that we get the correct value out
https://ldas-jobs.ligo.caltech.edu/~gareth.cabourndavies/pycbclive/combine_average_weighting/testing/H1-2023_07_14-2023_08_02-TRIGGER_FITS_COMBINED-counts.png
Change made to mean as well as conservative