Use SPDX license expression #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offbyone
reviewed
Nov 30, 2024
| @@ -7,7 +7,7 @@ name = "PyHamcrest" | |||
| description = "Hamcrest framework for matcher objects" | |||
| readme = "README.rst" | |||
| requires-python = ">= 3.8" | |||
| license = { file = "LICENSE.txt" } | |||
| license = "BSD-3-Clause" | |||
There was a problem hiding this comment.
I don't want to lose the license file, and according to PEP-639 we don't have to:
Suggested change
| license = "BSD-3-Clause" | |
| license = "BSD-3-Clause" | |
| license-files = ["LICENSE.txt"] |
There was a problem hiding this comment.
I don't want to lose the license file
Hatchling does implement default globs if license-files is missing. So it would have been included anyway. It doesn't hurt to spell it out explicitly either though.
https://github.com/pypa/hatch/blob/hatchling-v1.26.3/backend/src/hatchling/metadata/core.py#L748-L749
There was a problem hiding this comment.
I don't guarantee that we'll always use Hatchling. Explicit, as always, is better than implicit :D
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hatch recommends the use of SPDX license expressions.
https://spdx.org/licenses/BSD-3-Clause.html