Skip to content

Use SPDX license expression #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
offbyone merged 3 commits into from
Nov 30, 2024
Merged

Use SPDX license expression #259

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea26ddc
Merge pull request #258 from offbyone/actions-speed
offbyone Nov 2, 2024
a97b5cc
Use SPDX license expression
cdce8p Nov 17, 2024
f963a92
Include the license file too
offbyone Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ name = "PyHamcrest"
description = "Hamcrest framework for matcher objects"
readme = "README.rst"
requires-python = ">= 3.8"
license = { file = "LICENSE.txt" }
license = "BSD-3-Clause"
Copy link
Member

@offbyone offbyone Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to lose the license file, and according to PEP-639 we don't have to:

Suggested change
license = "BSD-3-Clause"
license = "BSD-3-Clause"
license-files = ["LICENSE.txt"]

Copy link
Contributor Author

@cdce8p cdce8p Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to lose the license file

Hatchling does implement default globs if license-files is missing. So it would have been included anyway. It doesn't hurt to spell it out explicitly either though.
https://github.com/pypa/hatch/blob/hatchling-v1.26.3/backend/src/hatchling/metadata/core.py#L748-L749

Copy link
Member

@offbyone offbyone Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't guarantee that we'll always use Hatchling. Explicit, as always, is better than implicit :D

license-files = ["LICENSE.txt"]
keywords = [
"hamcrest",
"matchers",
Expand All @@ -27,7 +28,6 @@ classifiers = [
"Development Status :: 5 - Production/Stable",
"Environment :: Console",
"Intended Audience :: Developers",
"License :: OSI Approved :: BSD License",
"Natural Language :: English",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3",
Expand Down