Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Added parkour and teleport messages to blockable messages #2348

Merged
merged 5 commits into from
Sep 7, 2024

Conversation

Not-a-cowfr
Copy link
Contributor

@Not-a-cowfr Not-a-cowfr commented Aug 15, 2024

What

Hides parkour and teleport pad messages. I wasn't able to test, I'M NOT SURE IF IT WORKS

Changelog Improvements

  • Added more options to the Chat Hider feature. - not_a_cow
    • Option to block parkour messages and teleport pad messages.

wasnt able to test, NOT SURE IF IT WORKS
added additional messages, improved formatting
unconfident that this works
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use repo patterns and repo pattern lists along with regex tests

@Not-a-cowfr
Copy link
Contributor Author

Not-a-cowfr commented Aug 15, 2024

please use repo patterns and repo pattern lists along with regex tests

do i need a test for every message? or will one per list do? (sorry im not very familiar with this)

@hannibal002
Copy link
Owner

Please write at least one text line per unique pattern. In terms of lists this means one for every entry in the list.

@hannibal002 hannibal002 added this to the Version 0.27 milestone Aug 15, 2024
idk if i did this right
- added tests
- fixed typos (im very smart)
@jani270 jani270 added the Soon This Pull Request will be merged within the next couple of betas label Sep 7, 2024
@hannibal002 hannibal002 merged commit bb625d1 into hannibal002:beta Sep 7, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 7, 2024
MTOnline69 pushed a commit to MTOnline69/SkyHanni that referenced this pull request Sep 11, 2024
hannibal002#2348)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants