Improvement: Fix some regex tests from old pr #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasnt able to test, NOT SURE IF IT WORKS
added additional messages, improved formatting
unconfident that this works
idk if i did this right - added tests - fixed typos (im very smart)
Not-a-cowfr
changed the title
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
CalMWolfs
requested changes
Sep 10, 2024
src/main/java/at/hannibal2/skyhanni/features/chat/ChatFilter.kt
Outdated
Show resolved
Hide resolved
still no clue what you want me to do with "use repo patterns and repo pattern lists" not sure if im stupid or blind but i dont see why that is needed
Not-a-cowfr
force-pushed
the
hide-parkour-messages
branch
from
0ebe6e6
to
9bcc2bd
Compare
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
hannibal002
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I really dont know if there was a better way to update this, just following what nopo said because nopo is good at this stuff 🙏
old pr
Changelog Improvements