Backend: Add skyhanni notifications #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
hannibal002
added
the
Soon
github-actions
bot
removed
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added skyhanni notifications which appear the same as the notifications that neu has just we no longer use their code for it.
Can be tested with
/shtestnotification <message>Also re-enabled showing these notifications when there is missing neu repo data. There is a 3minute cooldown before a repo issue can be displayed again
We can switch some other user facing issues to use this instead of just a chat message because this is a lot more visible
Images
Changelog Technical Details