Replace unmaintained useragent dependency with useragent-ng#65
Replace unmaintained useragent dependency with useragent-ng#65johnwatson484 wants to merge 2 commits intohapijs:masterfrom
useragent dependency with useragent-ng#65Conversation
| it('exposes all methods and classes as named imports', () => { | ||
|
|
||
| expect(Object.keys(Scooter)).to.equal([ | ||
| expect(Object.keys(Scooter)).to.contain([ |
There was a problem hiding this comment.
Node 24 will include module.exports as named export whilst earlier versions will not.
Have changed test to preserve minimum expectations but avoid failure between versions.
|
It seems that the |
So they have. I've raised a in issue to see if it's intentionally not supporting Windows or if it's just an oversight. If they're not willing to support Windows, I'll look at other options. Whether that's another dependency or just parsing what's needed for Scooter myself. |
|
I've drafted PR #67 as an alternative to patch the vulnerability using a more popular library, however comes with the cost of requiring an adapter function. I do not wish to become a pest so I'll hold back on any further work to allow time to consider the direction you wish to take |
useragent dependencyuseragent dependency with useragent-ng
|
I think it's safe to say we can close this one now. |
useragentis no longer actively maintained and has several outstanding vulnerabilities within itself and an outdated version oftmp.This PR replaces
useragentwith maintained forkuseragent-ng.