Skip to content

Replace unmaintained useragent dependency with useragent-ng #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnwatson484 wants to merge 2 commits into from
Closed

Replace unmaintained useragent dependency with useragent-ng #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7f89b
Replace unmaintained useragent dependency
johnwatson484 Dec 21, 2025
a535b90
Update test to support Node 24
johnwatson484 Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
'use strict';

const Useragent = require('useragent');
const Useragent = require('useragent-ng');

// Requires semver be installed
require('useragent/features'); // Enhances Useragent

require('useragent-ng/features'); // Enhances Useragent

const internals = {};

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"dependencies": {
"semver": "^7.3.8",
"useragent": "^2.3.0"
"useragent-ng": "^2.4.5"
},
"devDependencies": {
"@hapi/code": "^9.0.0",
Expand Down
2 changes: 1 addition & 1 deletion test/esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe('import()', () => {

it('exposes all methods and classes as named imports', () => {

expect(Object.keys(Scooter)).to.equal([
expect(Object.keys(Scooter)).to.contain([
Copy link
Contributor Author

@johnwatson484 johnwatson484 Dec 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 24 will include module.exports as named export whilst earlier versions will not.

Have changed test to preserve minimum expectations but avoid failure between versions.

'default',
'plugin'
]);
Expand Down
Loading