Adding a campaign record and reworking scenario from header #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 21, 2025 11:30
…but check needed for the version
added 5 commits
July 22, 2025 16:42
… from test it's a weird version cause map version is valorised to 4.
added 2 commits
July 25, 2025 09:50
… save_version < 61.5
Shranar
commented
Jul 31, 2025
| .tox/ | ||
| *.pyc | ||
| *.sqlite | ||
| /.vs |
There was a problem hiding this comment.
Using Visual Studio to work
Shranar
commented
Jul 31, 2025
| If(lambda ctx: find_save_version(ctx) >= 50, Bytes(8)), | ||
| If(lambda ctx: find_save_version(ctx) >= 61.5, Flag), | ||
| If(lambda ctx: find_save_version(ctx) >= 63, Bytes(5)), | ||
| If(lambda ctx: find_save_version(ctx) >= 64.3 and ctx.game_type == 5, Bytes(4)), # Campaign ? |
There was a problem hiding this comment.
Crashed on the campaign replay parsing here, could use a check with previous version of the game
Shranar
commented
Jul 31, 2025
mgz/header/lobby.py
Outdated
| #If(lambda ctx: find_save_version(ctx) >= 26.16, Bytes(5)), | ||
| #If(lambda ctx: find_save_version(ctx) >= 37, Bytes(8)), | ||
| #If(lambda ctx: find_save_version(ctx) >= 64.3, Bytes(16)), | ||
| # We ignore those previous data for now they were making the GoToLobbyStart more complex without being meaningfull |
There was a problem hiding this comment.
I choose to ignore those bytes to make GoToLobbyStart easier to write but we are loosing some version knowledge, happy to hear feedback.
|
@happyleavesaoc I'm open to feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Saladin 3 (new record 64.3-campaign), I'm trying to fix the scenario part, what bother me is that those fixes are from the most recent version and might not be compatible with a previous one.