-
Couldn't load subscription status.
- Fork 51
Adding a campaign record and reworking scenario from header #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shranar
wants to merge
14
commits into
happyleavesaoc:master
Choose a base branch
from
Shranar:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b20f97a
Adding a campaign record and reworking scenario from header
ea32224
fix forgotten comma
f5bf102
ignore test on de-64.3-campaign for now
3d631fb
Added byte in DeHeader when parsing a campaign, should fixe the test …
3d230b4
Deheader if 64.3 and gametype == 5 1 -> 4, 4 bytes not just 1
9eb41fb
fixing DE disabled item
c21f0d8
fixing DeDisabled item
57d1941
reorg scenario data
bed7785
lobby parsing fixe okay Error on 13.17
be78f8a
changed GoToLobbyStart map introduction version, removed 13.17 record…
b3281fe
cleaning up, rewriting comments, de-64.3-campaign.aoe2record is passi…
49c991c
de-13.17.aoe2record back in the test, GoToLobbyStart use re.search if…
e93eb78
Merge branch 'happyleavesaoc:master' into master
Shranar 845b7fa
Merge branch 'master' into master
Shranar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,4 @@ venv/ | |
| .tox/ | ||
| *.pyc | ||
| *.sqlite | ||
| /.vs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -163,6 +163,7 @@ | |
| If(lambda ctx: find_save_version(ctx) >= 50, Bytes(8)), | ||
| If(lambda ctx: find_save_version(ctx) >= 61.5, Flag), | ||
| If(lambda ctx: find_save_version(ctx) >= 63, Bytes(5)), | ||
| If(lambda ctx: find_save_version(ctx) >= 64.3 and ctx.game_type == 5, Bytes(4)), # Campaign ? | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Crashed on the campaign replay parsing here, could use a check with previous version of the game |
||
| "unknown_count"/If(lambda ctx: find_save_version(ctx) >= 66.3, Int32ul), | ||
| If(lambda ctx: find_save_version(ctx) >= 66.3, Bytes(12)), | ||
| If(lambda ctx: find_save_version(ctx) >= 66.3, Array(lambda ctx: ctx.unknown_count, Bytes(4))), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Visual Studio to work