Skip to content

check #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

check #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ out_/
out_/*
out_/**

# proofreads
*.proofread

# note file
*.note

Expand Down
9 changes: 4 additions & 5 deletions antipattern/a-get-request-with-side-effects.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ tags: [http, get-request, side-effects, query-string]
layers: [views]
solinks: []
---
Often people construct views that have side, effects, for example:
Often people construct views that have side effects, for example:

<pre class="python"><code>def remove_comment(request, comment_pk):
Comment.objects.<b>filter(</b>
Expand All @@ -17,8 +17,7 @@ Often people construct views that have side, effects, for example:

# Why is it a problem?

Because this violates the HTTP standard. In the section [*safe methods* of the HTTP specifications&nbsp;<sup>[w3.org]</sup>](https://www.rfc-editor.org/rfc/rfc9110.html#name-safe-methods)
it specifies that:
This is a problem, because this violates the HTTP standard, specifically the section on [*safe methods* of the HTTP specifications&nbsp;<sup>[w3.org]</sup>](https://www.rfc-editor.org/rfc/rfc9110.html#name-safe-methods), which states that:

> In particular, the convention has been established **that the GET** and HEAD methods **SHOULD NOT have the significance** of taking an action **other than retrieval**. These methods **ought to be considered "safe"**.

Expand All @@ -30,11 +29,11 @@ browser with an additional GET request, whereas most browsers will do that for
a POST request.

Search engines have web crawlers that look for URLs on pages, and will make GET
requests to these pages to analyze the page that is returned and look for more
requests to these pages to analyze the response and look for more
URLs. This thus means that a GET request of such crawler might accidentally
create, remove and update entities.

Django also does not offer security mechanisms like a CSRF-token for GET
Django also does not provide security mechanisms like a CSRF-token for GET
requests. This thus makes [cross-site request forgery (CSRF)&nbsp;<sup>[wiki]</sup>](https://en.wikipedia.org/wiki/Cross-site_request_forgery)
easier.

Expand Down
Loading