-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VM schedules pages #1103
Add VM schedules pages #1103
Conversation
6bc1799
to
2c50eb2
Compare
0846983
to
a68a6cf
Compare
Let me rebase and test it again since backend PR has some minor change. |
Hi @WebberHuang1118 , @torchiaf , I've rebased this PR and ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend PR is merged. Could you use master-head deployment and try again? |
This pull request is now in conflict. Could you fix it @a110605? 🙏 |
Done rebase. |
LGTM, thans for the PR. Just a point, if the schedule is suspended, the GUI doesn't show the condition? For example, if the user suspends the schedule proactively, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UX lgtm. However, I feel the word "VM Schedule" is confusing. Maybe "VM Backup Schedule" is more clear?
@jillian-maroket @asettle What do you think about this term.
But user can still create snapshot schedule job from this page, that why I give it |
pkg/harvester/detail/harvesterhci.io.schedulevmbackup/BackupList.vue
Outdated
Show resolved
Hide resolved
pkg/rancher-components/src/components/Form/LabeledInput/LabeledInput.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments and there are some small regressions:
-
When you click on 'Replace existing' / 'Restore New' from Virtual Machine Snapshots page or Virtual Machine Schedules -> Snapshots tab:
- The UI is redirected to Backups create page rather than Snapshots create.
- If you hit Cancel the UI is redirected to Backups page. The redirection should be to Virtual Machine Snapshots or Virtual Machine Schedules -> Snapshots tab, depending on navigation history.
Virtual Machine Snapshots
Screencast.from.2024-09-26.14-37-07.webm
Virtual Machine Schedules -> Snapshots tab
Screencast.from.2024-09-26.14-45-53.webm
Consider that some button actions are in common between Snapshots and Backup models.
@@ -32,8 +32,8 @@ | |||
"@vue/test-utils": "1.2.1", | |||
"babel-eslint": "10.1.0", | |||
"core-js": "3.25.3", | |||
"cron-validator": "1.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should port this fix in rancher/dashboard.
- add VM schedule list/edit/details pages - add VM schedule column in vmbackup/vmsnapshot list pages - add action menu for VM - show volume backup error message in backup/snapshot detail volume tab Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
@WebberHuang1118 , could you help check why I can't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM UI side.
IMHO the 500 error should be handled backend side, but the error message is consistent: If I stop the VM schedule from which the VM backups was created, I can manually restore the backup into a new VM. |
Yes, the Harvester controller has the webhook to prevent restoring the snapshot/backup from a running schedule, since the backup/snapshots will be cleansed under the hood, leading to restore failure. By design, before restoring, the user should suspend the schedule first. |
Summary
Create VM Schedule
action for VM operation menuvolume backup error message
andreadyToUse
in backup/snapshot detail volume tab <- discussion conclusion with the teamcron-validator
andcronstrue
to the latest versionNote. this UI PR needs wait for backend PR harvester/harvester#6149 merge first.
PR Checklist
Related Issue #
harvester/harvester#6058
Technical notes summary
run
yarn install
before run up the harvester dashboardScreenshot/Video
create_scheduling.mov
update_schedule.mov
schedule_detail.mov
show_error_backup_target.mov
volume backup error message
andreadyToUse
in backup/snapshot detail volume tabvolume_backup_error.mov