Add console button tooltip and document link when button disabled #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
commented
Aug 26, 2024
a110605
changed the title
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
a110605
force-pushed
the
issue-5679
branch
2 times, most recently
from
3fe5913
to
56136ee
Compare
a110605
commented
Sep 2, 2024
| @@ -26,15 +31,14 @@ export default { | |||
| <Banner color="warning"> | |||
| <div> | |||
| <strong>{{ t('harvester.upgradePage.upgradeInfo.warning') }}:</strong> | |||
| <p v-clean-html="t('harvester.upgradePage.upgradeInfo.doc', {}, true)" class="mb-5"> | |||
| </p> | |||
| <p v-clean-html="t('harvester.upgradePage.upgradeInfo.doc', {url: upgradeLink}, true)" class="mb-5"></p> | |||
There was a problem hiding this comment.
target="_blank" is ignore when giving translation key via v-clean-html. (not open link in new tab)
It's resolved in rancher but not harvester dashboard..
PR: rancher#9928
Signed-off-by: andy.lee <andy.lee@suse.com>
There was a problem hiding this comment.
Thanks for creating the mapping file. We will need to update the links once the product docs are available on the SUSE doc site.
Please apply the suggested string change.
bk201
approved these changes
Sep 4, 2024
jillian-maroket
approved these changes
Sep 4, 2024
Signed-off-by: andy.lee <andy.lee@suse.com>
|
@mergify backport release-harvester-v1.4 |
✅ Backports have been created
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
doc-links.jsand auto construct the doc link with the harvester version in package.json.PR Checklist
Related Issue #
Screenshot/Video
console_url_tooltip.mov