Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console button tooltip and document link when button disabled (backport #1111) #1134

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 6, 2024

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #

Screenshot/Video

console_url_tooltip.mov

This is an automatic backport of pull request #1111 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit f2e04fb)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit b87877a)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit f7effb4)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 430c103)
@a110605 a110605 self-assigned this Sep 6, 2024
@a110605 a110605 added the Backport to v1.4 Backport PR target v1.4 label Sep 6, 2024
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit b56bdd4 into release-harvester-v1.4 Sep 6, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/release-harvester-v1.4/pr-1111 branch September 6, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant