Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out witness node from VM migration dropdown #1114

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Filter out witness node from VM migration dropdown #1114

merged 1 commit into from
Sep 2, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Aug 27, 2024 •
edited
Loading

Summary

Filter out witness node when VM migration

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue # [BUG] The witness node should not be selected as a migration target

Screenshot/Video

The harvester-node-1 is witness node. vm is deployed on harvester-node-0

Screenshot 2024-08-27 at 3 00 42 PM Screenshot 2024-08-27 at 5 29 55 PM

@a110605 a110605 self-assigned this Aug 27, 2024
@a110605 a110605 changed the title filter out witness node when VM migration filter out witness node when VM migration (TESTING) Aug 27, 2024
@a110605 a110605 changed the title filter out witness node when VM migration (TESTING) filter out witness node from VM migration dropdown (TESTING) Aug 27, 2024
@a110605 a110605 changed the title filter out witness node from VM migration dropdown (TESTING) Filter out witness node from VM migration dropdown (TESTING) Aug 27, 2024
@a110605 a110605 added the Bug Fix Something isn't working label Aug 27, 2024
@a110605
filter out witness node when VM migration
175b448 
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 changed the title Filter out witness node from VM migration dropdown (TESTING) Filter out witness node from VM migration dropdown Aug 27, 2024
@a110605 a110605 requested a review from bk201 August 30, 2024 02:37
Vicente-Cheng
Vicente-Cheng approved these changes Sep 2, 2024
View reviewed changes
Copy link

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@a110605 a110605 merged commit 16234e3 into harvester:master Sep 2, 2024
10 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented Sep 2, 2024

@mergify backport release-harvester-v1.3

@mergify Mergify
Copy link

mergify bot commented Sep 2, 2024 •
edited
Loading

backport release-harvester-v1.3

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
3 tasks
@a110605
Copy link
Collaborator Author

a110605 commented Sep 5, 2024

@mergify backport release-harvester-v1.4

@mergify Mergify
Copy link

mergify bot commented Sep 5, 2024 •
edited
Loading

backport release-harvester-v1.4

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 5, 2024
Merged
3 tasks
a110605 added a commit that referenced this pull request Sep 10, 2024
@a110605
Merge pull request #1125 from harvester/mergify/bp/release-harvester-…
7eed76e 
…v1.3/pr-1114

Filter out witness node from VM migration dropdown (backport #1114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vicente-Cheng Vicente-Cheng Vicente-Cheng approved these changes

@torchiaf torchiaf Awaiting requested review from torchiaf

@bk201 bk201 Awaiting requested review from bk201

Assignees

@a110605 a110605

Labels
Bug Fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a110605 @Vicente-Cheng