Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out witness node from VM migration dropdown (backport #1114) #1125

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 2, 2024

Summary

Filter out witness node when VM migration

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue # [BUG] The witness node should not be selected as a migration target

Screenshot/Video

The harvester-node-1 is witness node. vm is deployed on harvester-node-0

Screenshot 2024-08-27 at 3 00 42 PM Screenshot 2024-08-27 at 5 29 55 PM
This is an automatic backport of pull request #1114 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 16234e3)
@a110605 a110605 self-assigned this Sep 2, 2024
@a110605 a110605 added the Backport to v1.3 Backport PR target v1.3 label Sep 2, 2024
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but target to v1.3.3.

@a110605 a110605 merged commit 7eed76e into release-harvester-v1.3 Sep 10, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/release-harvester-v1.3/pr-1114 branch September 10, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.3 Backport PR target v1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants