Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port app-modal to harvester shell #1163

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Port app-modal to harvester shell #1163

merged 3 commits into from
Oct 4, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 23, 2024 •
edited
Loading

Summary

Rancher dashboard has already replace <modal> to <app-modal> in below two PRs

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
[BUG] Can't select the harvester version to upgrade in Rancher UI
[BUG] Rancher doesn't use dark mode in popup modals when in Harvester UI

Screenshot/Video

I've tested harvester

  • upgrade modal ✅
  • all modals in vm edit page ✅
  • generate support bundle modal✅
  • Novnc customKey modal✅

Test on embedded mode

Screenshot 2024-09-23 at 8 40 18 PM image

@a110605 a110605 self-assigned this Sep 23, 2024
@a110605 a110605 added Enhancement minor or greater UI enhancement Bug Fix Something isn't working and removed Enhancement minor or greater UI enhancement labels Sep 23, 2024
@a110605 a110605 force-pushed the port-app-modal branch 2 times, most recently from 996f851 to e2d28d5 Compare September 24, 2024 06:57
@a110605 a110605 marked this pull request as ready for review September 24, 2024 07:09
@a110605
Port app-modal into harvester shell
f57bda7 
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605
revert: take vm snapshot wording
28af337 
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605
remove this. in HarvesterDisk.vue
a4b590c 
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605
Copy link
Collaborator Author

a110605 commented Oct 3, 2024

Done rebase master

torchiaf
torchiaf approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/harvester/components/novnc/NovncConsoleCustomKeys.vue Show resolved Hide resolved
@a110605 a110605 merged commit 874e191 into harvester:master Oct 4, 2024
7 checks passed
@mergify mergify bot mentioned this pull request Oct 4, 2024
Merged
3 tasks
@a110605 a110605 mentioned this pull request Oct 4, 2024
Closed
@a110605
Copy link
Collaborator Author

a110605 commented Oct 15, 2024

@mergify backport release-harvester-v1.3

@mergify Mergify
Copy link

mergify bot commented Oct 15, 2024 •
edited
Loading

backport release-harvester-v1.3

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 15, 2024
Open
3 tasks
@a110605 a110605 mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf torchiaf approved these changes

Assignees

@a110605 a110605

Labels
Bug Fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a110605 @torchiaf