Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provisioned vGpus in VM's devices list. (backport #1154) #1174

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 25, 2024

Summary

It adds the vGpu devices tracked in VM's annotation to the VM's vGpu list.
Those vGpus are provisioned by Harvester when creating new clusters from Rancher.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Harvester Issue harvester/harvester#6638
Blocks rancher#11399

Occurred changes and/or fixed issues

Technical notes summary

  • We need to define how to remove the provisioned vGpus. cc @ibrokethecloud

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video


This is an automatic backport of pull request #1154 done by [Mergify](https://mergify.com).

@mergify mergify bot added the Conflicts label Sep 25, 2024
Copy link
Author

mergify bot commented Sep 25, 2024

Cherry-pick of ca6ff46 has failed:

On branch mergify/bp/release-harvester-v1.3/pr-1154
Your branch is up to date with 'origin/release-harvester-v1.3'.

You are currently cherry-picking commit ca6ff4699.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/harvester/config/labels-annotations.js
	both modified:   pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVGpuDevices/index.vue
	both modified:   pkg/harvester/models/kubevirt.io.virtualmachine.js

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf force-pushed the mergify/bp/release-harvester-v1.3/pr-1154 branch from 0df2567 to 4f3fcc7 Compare September 27, 2024 07:45
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 added Backport to v1.3 Backport PR target v1.3 and removed Conflicts labels Sep 30, 2024
@torchiaf torchiaf merged commit 2c19182 into release-harvester-v1.3 Oct 1, 2024
4 checks passed
@torchiaf torchiaf deleted the mergify/bp/release-harvester-v1.3/pr-1154 branch November 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.3 Backport PR target v1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants