Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add volume konwn issue docs #366

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

WuJun2016
Copy link
Contributor

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit d6260d3
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64d2c232354126000809e607
😎 Deploy Preview https://deploy-preview-366--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@vickyhella vickyhella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions

## Known Issues

### Volume created is not appearing in the volume list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Volume created is not appearing in the volume list
### The Volumes page does not show the created volume

### Volume created is not appearing in the volume list

On the volume list page, users with 'project-member' permissions cannot see the created volumes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On the volume list page, users with 'project-member' permissions cannot see the created volumes.
**Summary**: If you are using Harvester from Rancher, after creating a volume, **project_member** users cannot find the created volume on the **Volumes** page.
**Workaround**: You can refresh the **Volumes** page and the volume should display as expected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Consider adding the affected versions
  2. Not sure if refreshing the page or applying the harvester-v1.1.2-patch1 is the correct workaround. If applying the patch is the workaround, please add the instructions as well
  3. Consider linking to the github issue page

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 suggestions made by @vickyhella

@WuJun2016
Copy link
Contributor Author

@vickyhella @LucasSaintarbor PTAL again, thanks

Copy link
Contributor

@vickyhella vickyhella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some very small nits, and the rest are good to me!

versioned_docs/version-v1.1/volume/create-volume.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.1/volume/create-volume.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.1/volume/create-volume.md Outdated Show resolved Hide resolved
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nics and replaced terms with terms i.e. volume > volume


**Workaround**: You can temporarily change the Harvester plugin version to [v1.2.1-pitch1](https://github.com/harvester/dashboard/releases/tag/v1.1.2-patch1) from the Harvester UI.
1. Go to the Harvester UI and click `Advanced`. In the `Settings` list, find ` ui-plugin-index` and then click `⋮` > `Edit Setting`.
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Go to the Harvester UI and click `Advanced`. In the `Settings` list, find ` ui-plugin-index` and then click `` > `Edit Setting`.
1. Go to the **Advanced** > **Settings** page. Find the **ui-plugin-index** amd select **** > **Edit Setting**.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to to ? @LucasSaintarbor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WuJun2016 Fixed. Thanks for catching that

**Workaround**: You can temporarily change the Harvester plugin version to [v1.2.1-pitch1](https://github.com/harvester/dashboard/releases/tag/v1.1.2-patch1) from the Harvester UI.
1. Go to the Harvester UI and click `Advanced`. In the `Settings` list, find ` ui-plugin-index` and then click `⋮` > `Edit Setting`.
2. Change `value` to `https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Change `value` to `https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js`
2. Change the **Value** to **https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js**.

1. Go to the Harvester UI and click `Advanced`. In the `Settings` list, find ` ui-plugin-index` and then click `⋮` > `Edit Setting`.
2. Change `value` to `https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js`
3. In the `Settings` list, find `ui-source` and then click `⋮` > `Edit Setting`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. In the `Settings` list, find `ui-source` and then click `` > `Edit Setting`.
3. On the **Settings** page, find **ui-source** and select **** > **Edit Setting**.

2. Change `value` to `https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js`
3. In the `Settings` list, find `ui-source` and then click `⋮` > `Edit Setting`.
4. Change `value` to `External`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Change `value` to `External`.
4. Change the **Value** to **External** to use an external UI source.

### The Volumes page does not show the created volume

**Summary**: If you are using Harvester from Rancher, after creating a volume, **project_member** users cannot find the created volume on the **Volumes** page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Summary**: If you are using Harvester from Rancher, after creating a volume, **project_member** users cannot find the created volume on the **Volumes** page.
**Summary**: After creating a volume when using Harvester from Rancher, users with the project role **Project Member** cannot find the newly created volume on the **Volumes** page.

3. In the `Settings` list, find `ui-source` and then click `⋮` > `Edit Setting`.
4. Change `value` to `External`.
5. Log in again using the **project_member** user in Rancher.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Log in again using the **project_member** user in Rancher.
5. Log in again as a **Project Member** user in Rancher to view the newly created volume for your Harvester cluster.

@LucasSaintarbor
Copy link
Contributor

@WuJun2016 Should docs: add ui-plugin-index #365 be merged before merging this PR? Lmk if the suggestions (#366 (review)) are good, and I'll merge both. Thanks!

@WuJun2016
Copy link
Contributor Author

@WuJun2016 Should docs: add ui-plugin-index #365 be merged before merging this PR? Lmk if the suggestions (#366 (review)) are good, and I'll merge both. Thanks!

The two pr's are unrelated and you can merge them as much as you want.

PR comment Fix done. only #366 (comment) need you to confirm.

PTAL, Thanks

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some formatting changes, LGTM

@LucasSaintarbor LucasSaintarbor merged commit 42340f9 into harvester:main Aug 8, 2023
5 checks passed
vickyhella pushed a commit to vickyhella/harvester-docs that referenced this pull request Sep 4, 2023
* add volume konwn issue docs

* Small formatting changes

* Combined the two tables into one

---------

Co-authored-by: LucasSaintarbor <lucas.saintarbor@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants