-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add volume konwn issue docs #366
Conversation
✅ Deploy Preview for harvester-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some suggestions
## Known Issues | ||
|
||
### Volume created is not appearing in the volume list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Volume created is not appearing in the volume list | |
### The Volumes page does not show the created volume |
### Volume created is not appearing in the volume list | ||
|
||
On the volume list page, users with 'project-member' permissions cannot see the created volumes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the volume list page, users with 'project-member' permissions cannot see the created volumes. | |
**Summary**: If you are using Harvester from Rancher, after creating a volume, **project_member** users cannot find the created volume on the **Volumes** page. | |
**Workaround**: You can refresh the **Volumes** page and the volume should display as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Consider adding the affected versions
- Not sure if refreshing the page or applying the
harvester-v1.1.2-patch1
is the correct workaround. If applying the patch is the workaround, please add the instructions as well - Consider linking to the github issue page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 suggestions made by @vickyhella
d9e8741
to
c434224
Compare
@vickyhella @LucasSaintarbor PTAL again, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some very small nits, and the rest are good to me!
c434224
to
f72886e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nics and replaced terms
with terms i.e. volume
> volume
|
||
**Workaround**: You can temporarily change the Harvester plugin version to [v1.2.1-pitch1](https://github.com/harvester/dashboard/releases/tag/v1.1.2-patch1) from the Harvester UI. | ||
1. Go to the Harvester UI and click `Advanced`. In the `Settings` list, find ` ui-plugin-index` and then click `⋮` > `Edit Setting`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Go to the Harvester UI and click `Advanced`. In the `Settings` list, find ` ui-plugin-index` and then click `⋮` > `Edit Setting`. | |
1. Go to the **Advanced** > **Settings** page. Find the **ui-plugin-index** amd select **⋮** > **Edit Setting**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go to to ? @LucasSaintarbor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WuJun2016 Fixed. Thanks for catching that
**Workaround**: You can temporarily change the Harvester plugin version to [v1.2.1-pitch1](https://github.com/harvester/dashboard/releases/tag/v1.1.2-patch1) from the Harvester UI. | ||
1. Go to the Harvester UI and click `Advanced`. In the `Settings` list, find ` ui-plugin-index` and then click `⋮` > `Edit Setting`. | ||
2. Change `value` to `https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Change `value` to `https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js` | |
2. Change the **Value** to **https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js**. |
1. Go to the Harvester UI and click `Advanced`. In the `Settings` list, find ` ui-plugin-index` and then click `⋮` > `Edit Setting`. | ||
2. Change `value` to `https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js` | ||
3. In the `Settings` list, find `ui-source` and then click `⋮` > `Edit Setting`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. In the `Settings` list, find `ui-source` and then click `⋮` > `Edit Setting`. | |
3. On the **Settings** page, find **ui-source** and select **⋮** > **Edit Setting**. |
2. Change `value` to `https://releases.rancher.com/harvester-ui/plugin/harvester-release-harvester-v1.1.2-patch1/harvester-release-harvester-v1.1.2-patch1.umd.min.js` | ||
3. In the `Settings` list, find `ui-source` and then click `⋮` > `Edit Setting`. | ||
4. Change `value` to `External`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4. Change `value` to `External`. | |
4. Change the **Value** to **External** to use an external UI source. |
### The Volumes page does not show the created volume | ||
|
||
**Summary**: If you are using Harvester from Rancher, after creating a volume, **project_member** users cannot find the created volume on the **Volumes** page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Summary**: If you are using Harvester from Rancher, after creating a volume, **project_member** users cannot find the created volume on the **Volumes** page. | |
**Summary**: After creating a volume when using Harvester from Rancher, users with the project role **Project Member** cannot find the newly created volume on the **Volumes** page. |
3. In the `Settings` list, find `ui-source` and then click `⋮` > `Edit Setting`. | ||
4. Change `value` to `External`. | ||
5. Log in again using the **project_member** user in Rancher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5. Log in again using the **project_member** user in Rancher. | |
5. Log in again as a **Project Member** user in Rancher to view the newly created volume for your Harvester cluster. |
@WuJun2016 Should docs: add ui-plugin-index #365 be merged before merging this PR? Lmk if the suggestions (#366 (review)) are good, and I'll merge both. Thanks! |
f72886e
to
b53d451
Compare
The two pr's are unrelated and you can merge them as much as you want. PR comment Fix done. only #366 (comment) need you to confirm. PTAL, Thanks |
b53d451
to
08b8d93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some formatting changes, LGTM
* add volume konwn issue docs * Small formatting changes * Combined the two tables into one --------- Co-authored-by: LucasSaintarbor <lucas.saintarbor@suse.com>
Update v1.1
issue: harvester/harvester#3873 (comment)