Allow reloading some server timings #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows changing grace period and a few other things timing-related via HUP instead of just a restart. Tested manually via config changes and HUP.
johanbrandhorst
approved these changes
Sep 4, 2024
tmessi
approved these changes
Sep 4, 2024
louisruch
approved these changes
Sep 4, 2024
johanbrandhorst
added a commit
that referenced
this pull request
Sep 6, 2024
This was missed in #5071
Merged
johanbrandhorst
added a commit
that referenced
this pull request
Sep 6, 2024
This was missed in #5071
Merged
johanbrandhorst
added a commit
that referenced
this pull request
Sep 9, 2024
* internal/session: update variable name in test This was missed in #5071 * internal/tests/cluster: skip failing tests These tests will need to be fixed or removed. It is not clear why they are failing, but they are always failing. * Makefile: try upgrading golangci-lint * internal/host/plugin: fix flaky test Hosts contain IP addresses in string form, whose order is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows changing grace period and a few other things timing-related via HUP instead of just a restart.
Tested manually via config changes and HUP.