AppSideNav - Component branch (HDS-3800)
#2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Co-authored-by: Alex <alex-ju@users.noreply.github.com> Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
KristinLBradley
force-pushed
the
hds-3800-app-sidenav-component
branch
from
9224755
to
b4973a6
Compare
alex-ju
reviewed
Oct 30, 2024
packages/components/src/styles/@hashicorp/design-system-components.scss
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/app-side-nav/portal/index-test.js
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/app-side-nav/index-test.js
Outdated
Show resolved
Hide resolved
alex-ju
approved these changes
Oct 30, 2024
alex-ju
reviewed
Oct 30, 2024
alex-ju
reviewed
Oct 30, 2024
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will add the
AppSideNavcomponent to HDS but will not publish it. It will also un-publish the relatedAppHeadercomponent. (See related memo)🛠️ Detailed description
The majority of code was duplicated from the
SideNavand then modified to implement the newAppSideNavcomponent.Major differences of note:
AppSideNavhas an updated visual design using lighter colors than theSideNav:header,:footer,:body,:root:logo&:actionschild named blocks were removed (used in old :header)HeaderandHeader::HomeLinkchild components were removed.AppHeaderwhich already includes this(Spike of restructured List and ListTitle which may be explored in later iterations)
(Internal references: RFC, Meta CRD)
🔗 External links
👀 Component checklist
[ ] A changelog entry was added via [Changesets](Removed changelog as component will not be published) (https://github.com/changesets/changesets) if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.