Backport of [ui] Fixes an issue where shift+num would not open an eval on the evaluations index table into release/1.7.x #20053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/b-ui/fix-eval-ui-keynav-open/strangely-heroic-seal
branch
from
0234dff
to
64c0095
Compare
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
Ember Test Audit comparison
|
tgross
added
the
stage/needs-rebase
philrenaud
removed
the
stage/needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20047 to be assessed for backporting due to the inclusion of the label backport/1.7.x.
The below text is copied from the body of the original PR.
Because we have multiple links on the Evaluations page table (to open the eval in a sidebar, and also to open the job to which the eval is related), we used a keyboard event "keyup" binding to let a user do something like tab + enter or tab + space to open the sidebar.
This predated the general keyboard navigation convention in the Nomad UI of shift+01, shift+02 to open a list row item action. The "which key was pressed" guard on opening the sidebar prevents this sidebar from opening with shift+n, and this PR fixes that by passing in an explicit "keynav" string on command.
Overview of commits