Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of [ui] Fixes an issue where shift+num would not open an eval on the evaluations index table into release/1.7.x #20053

Closed
wants to merge 1 commit into from
Closed

Backport of [ui] Fixes an issue where shift+num would not open an eval on the evaluations index table into release/1.7.x #20053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/20047.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fixed an issue where keynav would not trigger evaluation sidebar expand
```
3 changes: 2 additions & 1 deletion ui/app/controllers/evaluations/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ export default class EvaluationsController extends Controller {
e instanceof MouseEvent ||
(e instanceof KeyboardEvent &&
(e.code === 'Enter' || e.code === 'Space')) ||
!e
!e ||
e === 'keynav'
) {
this.statechart.send('LOAD_EVALUATION', { evaluation });
}
Expand Down
2 changes: 1 addition & 1 deletion ui/app/templates/evaluations/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
<td data-test-id
{{keyboard-shortcut
enumerated=true
action=(fn this.handleEvaluationClick row.model)
action=(fn this.handleEvaluationClick row.model "keynav")
}}
>
{{row.model.shortId}}
Expand Down
Loading