-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] alert a user on the jobs index page when a deploying job requires manual promotion #20279
Draft
philrenaud
wants to merge
99
commits into
main
Choose a base branch
from
20240-ui-alert-a-user-on-the-jobs-index-page-when-a-deploying-job-requires-manual-promotion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
philrenaud
commented
Apr 3, 2024
•
edited
Loading
edited
Ember Test Audit comparison
|
philrenaud
force-pushed
the
20240-ui-alert-a-user-on-the-jobs-index-page-when-a-deploying-job-requires-manual-promotion
branch
from
April 9, 2024 14:29
722c468
to
14ab4b9
Compare
example usage: ``` $ cat jobs.json { "jobs": [ {"id": "clients", "namespace": "default"}, {"id": "fail"} ] } $ cat jobs.json | nomad operator api -X POST /v1/jobs/statuses | jq . ```
with ?index= query param e.g. ``` $ cat jobs.json | nomad operator api -X POST /v1/jobs/statuses?index=1681 | jq . ```
will need to read response headers for index, next_token
with iterator experiments
instead of bespoke ResultIterator experiments
testing.TB and UpsertAllocsRaw()
akin to jobsummary
mainly to for system job accounting
* modifyIndex-based pagination * modifyIndex gets its own column and pagination compacted with icons * A generic withPagination handler for mirage * Some live-PR changes * Pagination and button disabled tests * Job update handling tests for jobs index * assertion timeout in case of long setTimeouts * assert.timeouts down to 500ms * de-to-do * Clarifying comment and test descriptions
…he viz grow forever (#20458)
* Beginnings of a search box for filter expressions * jobSearchBox integration test * jobs list updateFilter initial test * Basic jobs list filtering tests * First attempt at side-by-side facets and search with a computed filter * Weirdly close to an iterative approach but checked isnt tracked properly * Big rework to make filter composition and decomposition work nicely with the url * Namespace facet dropdown added * NodePool facet dropdown added * hdsFacet for future testing and basic namespace filtering test * Namespace filter existence test * Status filtering * Node pool/dynamic facet test * Test patchups * Attempt at optimize test fix * Allocation re-load on optimize page explainer * The Big Un-Skip * Post-PR-review cleanup
philrenaud
force-pushed
the
bff-job-summary-fe-redux-untangle
branch
from
May 2, 2024 17:58
baa42fe
to
3350ebc
Compare
philrenaud
force-pushed
the
20240-ui-alert-a-user-on-the-jobs-index-page-when-a-deploying-job-requires-manual-promotion
branch
from
May 2, 2024 20:32
336755d
to
6bdb3fe
Compare
philrenaud
force-pushed
the
20240-ui-alert-a-user-on-the-jobs-index-page-when-a-deploying-job-requires-manual-promotion
branch
from
May 2, 2024 20:58
6bdb3fe
to
f66680a
Compare
philrenaud
force-pushed
the
20240-ui-alert-a-user-on-the-jobs-index-page-when-a-deploying-job-requires-manual-promotion
branch
from
May 6, 2024 14:46
f66680a
to
7f48efa
Compare
philrenaud
force-pushed
the
bff-job-summary-fe-redux-untangle
branch
2 times, most recently
from
May 6, 2024 17:57
fe8636c
to
3877fbf
Compare
philrenaud
commented
May 16, 2024
{{#unless @job.childStatuses}} | ||
<div class="status-cell"> | ||
<Hds::Badge @text="{{capitalize @job.aggregateAllocStatus.label}}" @color={{@job.aggregateAllocStatus.state}} @size="large" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: size="medium" here
tgross
added
the
stage/needs-rebase
This PR needs to be rebased on main before it can be backported to pick up new BPA workflows
label
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
stage/needs-rebase
This PR needs to be rebased on main before it can be backported to pick up new BPA workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.