Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] alert a user on the jobs index page when a deploying job requires manual promotion #20279

Draft
wants to merge 99 commits into
base: main
Choose a base branch
from

Commits on Apr 16, 2024

  1. api: new /jobs/statuses endpoint

    example usage:
    
    ```
    $ cat jobs.json
    {
      "jobs": [
        {"id": "clients", "namespace": "default"},
        {"id": "fail"}
      ]
    }
    
    $ cat jobs.json | nomad operator api -X POST /v1/jobs/statuses | jq .
    ```
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c46e711 View commit details
    Browse the repository at this point in the history
  2. make blocking-query block

    with ?index= query param e.g.
    
    ```
    $ cat jobs.json | nomad operator api -X POST /v1/jobs/statuses?index=1681 | jq .
    ```
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    30f82b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c32d019 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ba63f5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4653b7c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    209643c View commit details
    Browse the repository at this point in the history
  7. add Datacenters

    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ef1f8ee View commit details
    Browse the repository at this point in the history
  8. flat list of jobs

    will need to read response headers for index, next_token
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c98a90e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a85fe9b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    259de6e View commit details
    Browse the repository at this point in the history
  11. add JobVersion to allocs

    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    be7583d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f366cd6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    39b29d4 View commit details
    Browse the repository at this point in the history
  14. one /jobs/statuses3 to rule them all

    with iterator experiments
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3f882f9 View commit details
    Browse the repository at this point in the history
  15. use filters feature of paginator

    instead of bespoke ResultIterator experiments
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    927ec87 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c6579f1 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    07c0c9b View commit details
    Browse the repository at this point in the history
  18. server benchmarking

    testing.TB and UpsertAllocsRaw()
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    cbc9344 View commit details
    Browse the repository at this point in the history
  19. smart alloc

    akin to jobsummary
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    17b7d3d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    62eba50 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    6b22618 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    5fc64a0 View commit details
    Browse the repository at this point in the history
  23. fine, ok, copywrite header

    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9fa3de8 View commit details
    Browse the repository at this point in the history
  24. add NodeID to allocs

    mainly to for system job accounting
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    892318a View commit details
    Browse the repository at this point in the history
  25. misc tidying and rearranging

    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    64cf698 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    544b57f View commit details
    Browse the repository at this point in the history
  27. rpc tests

    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ea56874 View commit details
    Browse the repository at this point in the history
  28. misc...

    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a527a53 View commit details
    Browse the repository at this point in the history
  29. copyright test file

    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    817e354 View commit details
    Browse the repository at this point in the history
  30. revert "add JobSummary.Children.Desired"

    This reverts commit 6a8b132.
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    312c6d0 View commit details
    Browse the repository at this point in the history
  31. sort jobs by ModifyIndex

    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5a4665b View commit details
    Browse the repository at this point in the history
  32. add submit/modify time

    and rename ActiveDeploymentID
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    485f45b View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    4447725 View commit details
    Browse the repository at this point in the history
  34. sort by ModifyIndex *only*, and default reverse

    and move a namespace check
    and tweak some comments
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1b1944b View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    e125aeb View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    404c5c5 View commit details
    Browse the repository at this point in the history
  37. add LatestDeployment

    probably will remove ActiveDeploymentID later
    gulducat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b681e8b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. remove SmartAlloc

    gulducat committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f8ccbd0 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. remove vestigial test helper

    gulducat committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    21baaae View commit details
    Browse the repository at this point in the history
  2. remove separate Jobs RPC type

    put Statuses on Job instead
    and rename JobsStatuses* to JobStatuses*
    gulducat committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1f593d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. treat GET/POST the same

    gulducat committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    924935a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    3e0ab67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    869b4fc View commit details
    Browse the repository at this point in the history
  3. Revert "set/slice init size optimization"

    This reverts commit 3e0ab67.
    gulducat committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2b726dc View commit details
    Browse the repository at this point in the history
  4. drop ActiveDeploymentID

    in favor of LatestDeployment which has more info
    gulducat committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    73440c2 View commit details
    Browse the repository at this point in the history
  5. child job changes

    * add ability to include them at all: ?include_children=true
    * add ParentID to UIJob response, so they can be associated
      with the parent job
    * for parent jobs, ChildStatuses should always be an array,
      rather than nil (null)
    gulducat committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    13b1d77 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    f999fbf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e675f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c415a3 View commit details
    Browse the repository at this point in the history
  4. de-log

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3355da2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a137c3d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    207ea9c View commit details
    Browse the repository at this point in the history
  7. Hamburgers to sausages

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    af1d3a7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0294e16 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0755fec View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    24cd854 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bcb2419 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fcdc480 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d586c57 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    682aba6 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5354cd2 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    63847e9 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7d5dc4f View commit details
    Browse the repository at this point in the history
  18. Smarter cancellations

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d96f5a2 View commit details
    Browse the repository at this point in the history
  19. Reset abortController on index models run, and system/sysbatch jobs n…

    …ow have an improved groupCountSum computed property
    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bd7ae5e View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    f37c22b View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    746f48f View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    51064e9 View commit details
    Browse the repository at this point in the history
  23. Namespace fix

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    964e38b View commit details
    Browse the repository at this point in the history
  24. Unblock tests

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bfb6496 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    3720513 View commit details
    Browse the repository at this point in the history
  26. Lintfix

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a4221eb View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    57998e9 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    28df4f4 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    da9649f View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    2058c73 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    d8f97bc View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    52fcead View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    e1d6894 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    415642e View commit details
    Browse the repository at this point in the history
  35. Job list page size fixes

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    eb695f0 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    c19a422 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    d1201af View commit details
    Browse the repository at this point in the history
  38. Unbreak task unit test

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2b8dea2 View commit details
    Browse the repository at this point in the history
  39. Pre-sort sort

    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    69198f7 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    b02d33b View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    371d61d View commit details
    Browse the repository at this point in the history
  42. modifyIndex-based pagination (#20350)

    * modifyIndex-based pagination
    
    * modifyIndex gets its own column and pagination compacted with icons
    
    * A generic withPagination handler for mirage
    
    * Some live-PR changes
    
    * Pagination and button disabled tests
    
    * Job update handling tests for jobs index
    
    * assertion timeout in case of long setTimeouts
    
    * assert.timeouts down to 500ms
    
    * de-to-do
    
    * Clarifying comment and test descriptions
    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3c5a77a View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    da6fa95 View commit details
    Browse the repository at this point in the history
  44. [ui] Searching and filtering options (#20459)

    * Beginnings of a search box for filter expressions
    
    * jobSearchBox integration test
    
    * jobs list updateFilter initial test
    
    * Basic jobs list filtering tests
    
    * First attempt at side-by-side facets and search with a computed filter
    
    * Weirdly close to an iterative approach but checked isnt tracked properly
    
    * Big rework to make filter composition and decomposition work nicely with the url
    
    * Namespace facet dropdown added
    
    * NodePool facet dropdown added
    
    * hdsFacet for future testing and basic namespace filtering test
    
    * Namespace filter existence test
    
    * Status filtering
    
    * Node pool/dynamic facet test
    
    * Test patchups
    
    * Attempt at optimize test fix
    
    * Allocation re-load on optimize page explainer
    
    * The Big Un-Skip
    
    * Post-PR-review cleanup
    philrenaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3350ebc View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    bd139db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    02dcfe9 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. todo-squashing

    philrenaud committed May 6, 2024
    Configuration menu
    Copy the full SHA
    243d45c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a63e48 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    09b80eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    07a72cd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fb02dbe View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b4aa1fe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7f48efa View commit details
    Browse the repository at this point in the history